Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get client random if setting TlsSecrets on server #3481

Merged
merged 1 commit into from
Mar 8, 2023
Merged

get client random if setting TlsSecrets on server #3481

merged 1 commit into from
Mar 8, 2023

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Mar 7, 2023

OpenSSL only, contributes to #2344

@wfurt wfurt requested a review from a team as a code owner March 7, 2023 16:24
nibanks
nibanks approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@nibanks nibanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @anrossi, I'm ok with this as a temporary measure, but I'd really prefer a TLS-agnostic solution in the QUIC code, long term.

@anrossi
Copy link
Contributor

anrossi commented Mar 7, 2023

@nibanks Agreed. This is fine for now.

@wfurt
Copy link
Member Author

wfurt commented Mar 7, 2023

related to dotnet/runtime#83001. I work out hook in .NET (for debug build only)
I started with Linux as it was super easy to fix.
cc: @ManickaP

@nibanks nibanks merged commit b92b25c into microsoft:main Mar 8, 2023
@wfurt wfurt mentioned this pull request Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anrossi anrossi anrossi approved these changes

@nibanks nibanks nibanks approved these changes

Assignees
No one assigned
Labels
TLS: OpenSSL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wfurt @anrossi @nibanks